Upgrade pxapi pypi python dependencies#2143
Closed
ddelnano wants to merge 13 commits intopixie-io:mainfrom
Closed
Conversation
8ffa795 to
5996261
Compare
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
…to fully address Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
2316936 to
c26ed85
Compare
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
9aab4da to
b7f3782
Compare
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
NickLanam
reviewed
Apr 23, 2025
Member
There was a problem hiding this comment.
It amuses me that GitHub added me to this PR just because of one generated file
Member
Author
There was a problem hiding this comment.
Sorry for the noise! Should have moved this to a draft. I believe this proto file change is unexpected but I haven't figured out the cause yet.
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
5c7876b to
ac8e593
Compare
Member
Author
|
I'll be creating a new PR instead of updating this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Upgrade pxapi pypi python dependencies
The pxapi's dependencies haven't been updated in a long time. This PR upgrades the dependencies and the python version constraint to support 3.9 through 3.13.
One of the more complex parts of this change was replacing gogo-python with a bazel supplied equivalent. gogo-python is no longer updated and didn't support protobuf v3. In order to use the gogo repository supplied via
rules_goand our internal version (gogo_grpc_proto), the following changes were necessary:github/com/gogotogithub.com/gogorules_goand internal gogo bazel repository to place its files in a similarly named directory (github/com/gogo)github/com/gogo/...instead ofgithub.com/gogo/...This is due to the fact that Python does not support periods in module names.
rules_goand our internal gogo repository (gogo_grpc_proto) used a directory structure and a protobuf compiler patch that resulting in non functional python code (a module namedgithub.comis created). This change renames therules_goand internal gogo repository to usegithub/com/gogo/...instead of the previousgithub.com/gogonaming.One slight change I considered was removing the use of the
rules_gogogo repository in our targets. This would hopefully avoid the need to patchrules_gowith the samegithub.com->github/comchange. I'm not sure if any third party code relies on gogo that would complicate this simplification. I wanted to get feedback on this PR's direction before moving forward with that.Relevant Issues: #2140
Type of change: /kind cleanup
Test Plan: Existing unit tests and the following:
pip installworks for python in 3.9 docker containersrc/api/python/exampleswith python 3.9 and 3.13Python 3.9 and 3.13 test
Changelog Message: Upgrade the pxapi python module's third party dependencies and support Python 3.11 through 3.13